[webkit-reviews] review granted: [Bug 181138] [GTK] Crash destroying WebCore::FileMonitor : [Attachment 330311] Speculative fix

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 181138: [GTK] Crash destroying WebCore::FileMonitor
https://bugs.webkit.org/show_bug.cgi?id=181138

Attachment 330311: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=330311&action=review




--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 330311
  --> https://bugs.webkit.org/attachment.cgi?id=330311
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=330311&action=review

I think the code changes are right.

It would be good to add a comment to document the thread-safety semantics of
FileMonitor, since this has proven to be a tricky bit of code. Right now, it's
not clear to the reader why the create/destroy operations need to be
synchronous.

> Source/WebCore/platform/glib/FileMonitorGLib.cpp:60
> +    // The monitor can be destroyed in the work queue thread.
> +    if (&m_handlerQueue->runLoop() == &RunLoop::current())
> +	   return;

Good catch.