[webkit-reviews] review granted: [Bug 181205] Make MessagePortChannel::takeAllMessagesFromRemote asynchronous : [Attachment 330333] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 181205: Make MessagePortChannel::takeAllMessagesFromRemote asynchronous
https://bugs.webkit.org/show_bug.cgi?id=181205

Attachment 330333: Patch

https://bugs.webkit.org/attachment.cgi?id=330333&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 330333
  --> https://bugs.webkit.org/attachment.cgi?id=330333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330333&action=review

> Source/WebCore/dom/MessagePort.cpp:206
> +    m_entangledChannel->takeAllMessagesFromRemote([protectedThis =
makeRef(*this), this](Deque<std::unique_ptr<MessagePortChannel::EventData>>&&
messages) {

I like to capture this first.  I don't think we've discussed this style.  Pun
intended.

> Source/WebCore/dom/MessagePortChannel.h:70
> +    virtual void
takeAllMessagesFromRemote(WTF::Function<void(Deque<std::unique_ptr<EventData>>&
&)>&&) = 0;

We shouldn't need the WTF:: prefix since r222473.  This could also be a
CompletionHandler.