[webkit-reviews] review granted: [Bug 181186] Remove std::chrono completely : [Attachment 330256] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 181186: Remove std::chrono completely
https://bugs.webkit.org/show_bug.cgi?id=181186

Attachment 330256: Patch

https://bugs.webkit.org/attachment.cgi?id=330256&action=review




--- Comment #20 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 330256
  --> https://bugs.webkit.org/attachment.cgi?id=330256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330256&action=review

> Source/WebCore/platform/network/HTTPParsers.cpp:260
>	   return { };

std::nullopt

> Source/WebKit/Platform/IPC/ArgumentCoders.cpp:53
> +    double value;
> +    if (!decoder.decode(value))

Let's keep the new pattern:
std::optional<double> time;
decoder >> time;
if (!time)
    return std::nullopt;