[webkit-reviews] review granted: [Bug 181187] [WPE][GTK] Implement the assignment of ProcessIdentifiers to child processes : [Attachment 330300] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 181187: [WPE][GTK] Implement the assignment of ProcessIdentifiers to child
processes
https://bugs.webkit.org/show_bug.cgi?id=181187

Attachment 330300: Patch

https://bugs.webkit.org/attachment.cgi?id=330300&action=review




--- Comment #6 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 330300
  --> https://bugs.webkit.org/attachment.cgi?id=330300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330300&action=review

LGTM

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:97
> +    GUniquePtr<gchar> processIdentifier(g_strdup_printf("%" PRIu64,
m_launchOptions.processIdentifier.toUInt64()));

Whole patch is precisely what I tried to do blind except I had no way of
verifying this line. :) Thanks!