[webkit-reviews] review granted: [Bug 183212] [GStreamer] text samples no longer processed : [Attachment 334742] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 28 23:51:56 PST 2018


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 183212: [GStreamer] text samples no longer processed
https://bugs.webkit.org/show_bug.cgi?id=183212

Attachment 334742: Patch

https://bugs.webkit.org/attachment.cgi?id=334742&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 334742
  --> https://bugs.webkit.org/attachment.cgi?id=334742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334742&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:986
> +	   for (auto track : m_textTracks.values()) {

Nit: you better do auto& instead.


More information about the webkit-reviews mailing list