[webkit-reviews] review denied: [Bug 183231] Scrollbar preferences are ignored when the WebContent process doesn't have access to the WindowServer. : [Attachment 334784] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 28 17:16:44 PST 2018
Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183231: Scrollbar preferences are ignored when the WebContent process
doesn't have access to the WindowServer.
https://bugs.webkit.org/show_bug.cgi?id=183231
Attachment 334784: Patch
https://bugs.webkit.org/attachment.cgi?id=334784&action=review
--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 334784
--> https://bugs.webkit.org/attachment.cgi?id=334784
Patch
I think this seems good overall, but fails to build on any of the mac
platforms. This might be an SDK difference between Sierra and High Sierra.
Likely just a missing include. r- to fix the build.
More information about the webkit-reviews
mailing list