[webkit-reviews] review granted: [Bug 183218] Add a second tier of prevalence to facilitate telemetry on very prevalent domains : [Attachment 334755] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 183218: Add a second tier of prevalence to facilitate telemetry on very
prevalent domains
https://bugs.webkit.org/show_bug.cgi?id=183218

Attachment 334755: Patch

https://bugs.webkit.org/attachment.cgi?id=334755&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 334755
  --> https://bugs.webkit.org/attachment.cgi?id=334755
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334755&action=review

r=me

> Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp:37
> +    return sqrt(a * a + b * b + c * c);

This could probably be "std::hypot(a, b, c)", though I think this is known to
be faster to execute.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:532
> +{

ASSERT(isMainThread());

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:547
> +	   resourceStatistic.isVeryPrevalentResource = true;

resourceStatistic.isVeryPrevalentResource = newPrevlance ==
ResourceLoadPrevalence::VeryHigh;

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:576
> +{

ASSERT(isMainThread());