[webkit-reviews] review granted: [Bug 183080] Make LibWebRTCProvider port agnostic again after r215424 : [Attachment 334736] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 28 10:46:39 PST 2018


youenn fablet <youennf at gmail.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 183080: Make LibWebRTCProvider port agnostic again after r215424
https://bugs.webkit.org/show_bug.cgi?id=183080

Attachment 334736: Patch

https://bugs.webkit.org/attachment.cgi?id=334736&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 334736
  --> https://bugs.webkit.org/attachment.cgi?id=334736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334736&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:49
> +#if PLATFORM(COCOA)

We probably want to keep the case of COCOA platform that would not use
libwebrtc for now.
So we probably want to keep the USE(LIBWEBRTC) check here.

Can we move this implementation of LibWebRTCProvider::create to
LibWebRTCProviderCocoa.cpp as is?
That could remove the need to update LibWebRTCProviderCocoa class.


More information about the webkit-reviews mailing list