[webkit-reviews] review granted: [Bug 183171] Rename samplePendingBuild to samplePendingBuildRequest : [Attachment 334700] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 28 01:50:25 PST 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 183171: Rename samplePendingBuild to samplePendingBuildRequest
https://bugs.webkit.org/show_bug.cgi?id=183171
Attachment 334700: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=334700&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334700
--> https://bugs.webkit.org/attachment.cgi?id=334700
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334700&action=review
> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:318
> +function samplePendingBuildRequest(buildRequestId, buildTime, builderName)
Should be samplePendingBuildRequests since this function returns a list of
build requests
even though it always contains one.
More information about the webkit-reviews
mailing list