[webkit-reviews] review granted: [Bug 183189] Ensure target triple is propagated correctly to DerivedSources.make : [Attachment 334710] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183189: Ensure target triple is propagated correctly to DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=183189

Attachment 334710: Patch

https://bugs.webkit.org/attachment.cgi?id=334710&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 334710
  --> https://bugs.webkit.org/attachment.cgi?id=334710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334710&action=review

> Source/WebCore/Configurations/Base.xcconfig:121
> +LLVM_TARGET_TRIPLE_SUFFIX = $(inherited);

I can easily picture myself trying to be helpful by removing this
seemingly-redundant assignment. Can you add a comment explaining why it’s
needed?