[webkit-reviews] review granted: [Bug 183100] [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior : [Attachment 334565] Fix macOS builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 26 14:08:19 PST 2018


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 183100: [Extra zoom mode] Implement additional SPI for adjusting viewport
shrink-to-fit behavior
https://bugs.webkit.org/show_bug.cgi?id=183100

Attachment 334565: Fix macOS builds

https://bugs.webkit.org/attachment.cgi?id=334565&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 334565
  --> https://bugs.webkit.org/attachment.cgi?id=334565
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=334565&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509
> +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds
outViewSize:(WebCore::FloatSize&)viewSize

This is a little ugly (the out arg), but I’m not sure what else to do.


More information about the webkit-reviews mailing list