[webkit-reviews] review granted: [Bug 183137] [Web Animations] Implement the procedure to set the start time : [Attachment 334632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 26 13:02:18 PST 2018


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183137: [Web Animations] Implement the procedure to set the start time
https://bugs.webkit.org/show_bug.cgi?id=183137

Attachment 334632: Patch

https://bugs.webkit.org/attachment.cgi?id=334632&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 334632
  --> https://bugs.webkit.org/attachment.cgi?id=334632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334632&action=review

> Source/WebCore/animation/WebAnimation.cpp:211
> +	   setStartTime(std::nullopt);

Is hold time start time? Why isn't this setHoldTime?


More information about the webkit-reviews mailing list