[webkit-reviews] review granted: [Bug 183075] Release assertion in WebPage::updatePreferences : [Attachment 334568] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 183075: Release assertion in WebPage::updatePreferences
https://bugs.webkit.org/show_bug.cgi?id=183075

Attachment 334568: Patch

https://bugs.webkit.org/attachment.cgi?id=334568&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 334568
  --> https://bugs.webkit.org/attachment.cgi?id=334568
Patch

r=me with non sw-enabled build fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=334568&action=review

> Source/WebKit/StorageProcess/StorageProcess.cpp:191
> +	   return;

The work done here seems harmless so maybe we can do it anyway, especially
since we are disabling any IPC to Messages::WebSWServerToContextConnection?
I am not familiar with this routine but maybe there is a chance for a race
condition somehow so that we initialize the website data store first and get
the entitlement later on.