[webkit-reviews] review granted: [Bug 183116] [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used : [Attachment 334590] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 25 23:37:12 PST 2018


Zan Dobersek <zan at falconsigh.net> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 183116: [CMake][OpenVR] Linkage errors happen because only OpenVR is
compiled with -stdlib=libc++ if Clang is used
https://bugs.webkit.org/show_bug.cgi?id=183116

Attachment 334590: Patch

https://bugs.webkit.org/attachment.cgi?id=334590&action=review




--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 334590
  --> https://bugs.webkit.org/attachment.cgi?id=334590
Patch

LGTM. I guess the whole "Enable some properties" section could be removed in
the future.


More information about the webkit-reviews mailing list