[webkit-reviews] review denied: [Bug 183078] [WebKit] Fix Clang unused parameter warnings of NetworkProcess : [Attachment 334514] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied  review:
Bug 183078: [WebKit] Fix Clang unused parameter warnings of NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=183078

Attachment 334514: Patch

https://bugs.webkit.org/attachment.cgi?id=334514&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334514
  --> https://bugs.webkit.org/attachment.cgi?id=334514
Patch

No, we agreed to build WebKit2 without -Wunused-parameter. (For better or for
worse; I actually like that warning.)

Fujii, why are you getting these warnings in your build? It should be
suppressed by this block in Source/WebKit/CMakeLists.txt:

if (COMPILER_IS_GCC_OR_CLANG)
    WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -Wno-unused-parameter)
    WEBKIT_ADD_TARGET_CXX_FLAGS(WebProcess -Wno-unused-parameter)
    WEBKIT_ADD_TARGET_CXX_FLAGS(NetworkProcess -Wno-unused-parameter)
    WEBKIT_ADD_TARGET_CXX_FLAGS(StorageProcess -Wno-unused-parameter)
endif ()