[webkit-reviews] review granted: [Bug 183066] Crash under SchemeRegistry::shouldTreatURLSchemeAsLocal(WTF::String const&) : [Attachment 334552] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183066: Crash under SchemeRegistry::shouldTreatURLSchemeAsLocal(WTF::String
const&)
https://bugs.webkit.org/show_bug.cgi?id=183066

Attachment 334552: Patch

https://bugs.webkit.org/attachment.cgi?id=334552&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334552
  --> https://bugs.webkit.org/attachment.cgi?id=334552
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334552&action=review

> Source/WebCore/page/SecurityOrigin.cpp:127
> +    if (SchemeRegistry::shouldTreatURLSchemeAsSecure(protocol))
>	   return true;

I think there is still a thread safety issue from the string hasher
but I think this patch still fixes the majority of thread safety issues over
the status quo.
Please add a FIXME here.

> Source/WebCore/page/SecurityOrigin.cpp:224
> +    // This code is using an enum instead of an std::optional for
thread-safety. Worse case scenario, several thread will read

Nit: "Worse case" -> "The worst case".