[webkit-reviews] review canceled: [Bug 183066] Crash under SchemeRegistry::shouldTreatURLSchemeAsLocal(WTF::String const&) : [Attachment 334494] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183066: Crash under SchemeRegistry::shouldTreatURLSchemeAsLocal(WTF::String
const&)
https://bugs.webkit.org/show_bug.cgi?id=183066

Attachment 334494: Patch

https://bugs.webkit.org/attachment.cgi?id=334494&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 334494
  --> https://bugs.webkit.org/attachment.cgi?id=334494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334494&action=review

>> Source/WebCore/page/SecurityOrigin.cpp:223
>> +{
> 
> Are you sure this function is only called by a single thread at a time?
> If this function can be called synchronously from multiple threads, we have
mutate m_isPotentiallyTrustworthy from multiple threads.

I don't think this is guaranteed :/ SecurityOrigin are frequently passed across
threads. You are right that there is a bug here.