[webkit-reviews] review granted: [Bug 183051] [Curl] Cookie Database files are wrongfully getting deleted when the database is opened : [Attachment 334547] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 23 15:15:10 PST 2018
Per Arne Vollan <pvollan at apple.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 183051: [Curl] Cookie Database files are wrongfully getting deleted when
the database is opened
https://bugs.webkit.org/show_bug.cgi?id=183051
Attachment 334547: Patch
https://bugs.webkit.org/attachment.cgi?id=334547&action=review
--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 334547
--> https://bugs.webkit.org/attachment.cgi?id=334547
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334547&action=review
R=me.
> Source/WebCore/platform/network/curl/CookieJarDB.cpp:167
> + FileSystem::closeFile(handle);
Should we check whether 'handle' is valid before closing?
More information about the webkit-reviews
mailing list