[webkit-reviews] review granted: [Bug 183071] [JSC] Implement $vm.ftlTrue function for FTL testing : [Attachment 334536] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183071: [JSC] Implement $vm.ftlTrue function for FTL testing
https://bugs.webkit.org/show_bug.cgi?id=183071

Attachment 334536: Patch

https://bugs.webkit.org/attachment.cgi?id=334536&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 334536
  --> https://bugs.webkit.org/attachment.cgi?id=334536
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334536&action=review

r=me with suggestions.

> Source/JavaScriptCore/jsc.cpp:-292
>  static EncodedJSValue JSC_HOST_CALL functionFalse1(ExecState*);
> -static EncodedJSValue JSC_HOST_CALL functionFalse2(ExecState*);

You can rename functionFalse1 to functionFalse now that there's only one.

> Source/JavaScriptCore/jsc.cpp:518
> -	   putDirectNativeFunction(vm, this, Identifier::fromString(&vm,
"isFinalTier"), 0, functionFalse2, IsFinalTierIntrinsic,
static_cast<unsigned>(PropertyAttribute::DontEnum));
> +	   putDirectNativeFunction(vm, this, Identifier::fromString(&vm,
"isFinalTier"), 0, functionFalse1, IsFinalTierIntrinsic,
static_cast<unsigned>(PropertyAttribute::DontEnum));

Ditto.	Use functionFalse.

> Source/JavaScriptCore/jsc.cpp:-1831
>  EncodedJSValue JSC_HOST_CALL functionFalse1(ExecState*) { return
JSValue::encode(jsBoolean(false)); }
> -EncodedJSValue JSC_HOST_CALL functionFalse2(ExecState*) { return
JSValue::encode(jsBoolean(false)); }

Ditto.	Use functionFalse.

> JSTests/stress/has-indexed-property-array-storage-ftl.js:8
> +var flag = false;

I suggest renaming "flag" to "didFTLCompile".

> JSTests/stress/has-indexed-property-slow-put-array-storage-ftl.js:8
> +var flag = false;

I suggest renaming "flag" to "didFTLCompile".