[webkit-reviews] review denied: [Bug 183045] Expose still more WKPreferences SPI to match C SPI : [Attachment 334486] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 183045: Expose still more WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=183045

Attachment 334486: Patch

https://bugs.webkit.org/attachment.cgi?id=334486&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 334486
  --> https://bugs.webkit.org/attachment.cgi?id=334486
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334486&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:1091
> +   
WebCore::DeprecatedGlobalSettings::setLowPowerVideoAudioBufferSizeEnabled(enabl
ed);

This is probably setting a bool in the wrong process.

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:166
> + at property (nonatomic, setter=_setAVFoundationNSURLSessionEnabled:) BOOL
_avFoundationNSURLSessionEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));

This should always be enabled.