[webkit-reviews] review granted: [Bug 182682] [WinCairo] WebKit2_C.h should be included for TestWebKit : [Attachment 333683] bz182682-2.patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 182682: [WinCairo] WebKit2_C.h should be included for TestWebKit
https://bugs.webkit.org/show_bug.cgi?id=182682

Attachment 333683: bz182682-2.patch

https://bugs.webkit.org/attachment.cgi?id=333683&action=review




--- Comment #8 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 333683
  --> https://bugs.webkit.org/attachment.cgi?id=333683
bz182682-2.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333683&action=review

>> Tools/TestWebKitAPI/config.h:64
>> +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) ||
defined(BUILDING_WIN_CAIRO_WEBKIT))
> 
> Why doesn't `PLATFORM(WIN_CAIRO)` work?

OK, so please note that we will remove `BUILDING_WIN_CAIRO_WEBKIT` once
WinCairo WebKit is done (and non optional).