[webkit-reviews] review denied: [Bug 183072] Clang reports undefined reference errors of poison variables while building LLIntOffsetsExtractor with -gsplit-dwarf : [Attachment 334505] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 183072: Clang reports undefined reference errors of poison variables while
building LLIntOffsetsExtractor with -gsplit-dwarf
https://bugs.webkit.org/show_bug.cgi?id=183072

Attachment 334505: Patch

https://bugs.webkit.org/attachment.cgi?id=334505&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 334505
  --> https://bugs.webkit.org/attachment.cgi?id=334505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334505&action=review

> Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:69
> +#define DEFINE_POISON(poisonID) \
> +    uintptr_t POISON_KEY_NAME(poisonID);
> +FOR_EACH_JSC_POISON(DEFINE_POISON)

Why is this necessary at all?  We don't ever use these as offsets.  So, I find
it suspicious that we need them here.

Secondly, the LLInt asm code only refers to them as global addresses that
should come from the JavaScriptCore library.  Fabricating a second set of such
variables here in LLIntOffsetsExtractor will only at best stop the compiler
from complaining, but any addresses or offsets generated from these will have
nothing to do with the versions in the JavaScriptCore library.	As such, you'll
definitely be getting wrong values.  Hence, I'm not sure that this is not the
right solution.  r- for now.

Can you explain what -gsplit-dwarf is and what does it have to do with
triggering this issue?