[webkit-reviews] review granted: [Bug 182982] ArgumentsEliminationPhase has a branch on GetByOffset that should be an assert : [Attachment 334491] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 22 18:37:32 PST 2018
Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 182982: ArgumentsEliminationPhase has a branch on GetByOffset that should
be an assert
https://bugs.webkit.org/show_bug.cgi?id=182982
Attachment 334491: patch
https://bugs.webkit.org/attachment.cgi?id=334491&action=review
--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 334491
--> https://bugs.webkit.org/attachment.cgi?id=334491
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334491&action=review
r=me
> Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp:711
> + ASSERT(node->child2()->op() == PhantomClonedArguments);
Let's use `ASSERT(candidate->op() == PhantomClonedArguments)`.
More information about the webkit-reviews
mailing list