[webkit-reviews] review denied: [Bug 182924] Potential privacy issue: DNS prefetching can be re-enabled : [Attachment 334442] proposed patch ][

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Milan Crha
<mcrha at redhat.com>'s request for review:
Bug 182924: Potential privacy issue: DNS prefetching can be re-enabled
https://bugs.webkit.org/show_bug.cgi?id=182924

Attachment 334442: proposed patch ][

https://bugs.webkit.org/attachment.cgi?id=334442&action=review




--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334442
  --> https://bugs.webkit.org/attachment.cgi?id=334442
proposed patch ][

View in context: https://bugs.webkit.org/attachment.cgi?id=334442&action=review

> Source/WebCore/dom/Document.cpp:5765
> +    // let the page only disable prefetching, not enable it

WebKit style is to write the comment as a full sentence, with a capital L and a
period at the end.

>> Source/WebCore/dom/Document.cpp:-5769
>> -	m_haveExplicitlyDisabledDNSPrefetch = true;
> 
> I do not understand why it is OK to drop this flag. This flag has nothing to
do with the page setting.

I think m_haveExplicitlyDisabledDNSPrefetch is there to ensure that if prefetch
is disabled, either with the HTTP header or HTML meta http-equiv, it can't ever
be reenabled the same way. Thanks for trying to clean up the code, but I think
we should keep it.