[webkit-reviews] review denied: [Bug 183042] Add release logging for CacheStorage::Engine disk related functions : [Attachment 334456] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied  review:
Bug 183042: Add release logging for CacheStorage::Engine disk related functions
https://bugs.webkit.org/show_bug.cgi?id=183042

Attachment 334456: Patch

https://bugs.webkit.org/attachment.cgi?id=334456&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 334456
  --> https://bugs.webkit.org/attachment.cgi?id=334456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334456&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:285
> +		   RELEASE_LOG_ERROR(CacheStorage,
"CacheStorage::Engine::writeFile failed with error %d", error);

An engine has an associated sessionID. You should check that the sessionID is
not one for an ephemeral session before logging.