[webkit-reviews] review granted: [Bug 183002] [GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes) : [Attachment 334375] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 183002: [GStreamer] HTTP totalBytes query returns 0 after seeking
(sometimes)
https://bugs.webkit.org/show_bug.cgi?id=183002

Attachment 334375: Patch

https://bugs.webkit.org/attachment.cgi?id=334375&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 334375
  --> https://bugs.webkit.org/attachment.cgi?id=334375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86
>> +	gboolean haveSize;
> 
> This attribute is only for internal usage and doesn't interact with Glib. Why
not using a C++ bool type, like for "paused" or "isSeeking"?

I was going to mention exactly the same thing :)