[webkit-reviews] review requested: [Bug 183025] Add release asserts for service worker fetch and postMessage events : [Attachment 334426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 21 17:50:47 PST 2018


youenn fablet <youennf at gmail.com> has asked  for review:
Bug 183025: Add release asserts for service worker fetch and postMessage events
https://bugs.webkit.org/show_bug.cgi?id=183025

Attachment 334426: Patch

https://bugs.webkit.org/attachment.cgi?id=334426&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 334426
  --> https://bugs.webkit.org/attachment.cgi?id=334426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334426&action=review

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:188
> +    RELEASE_ASSERT(url.isEmpty() || !url.protocolIsInHTTPFamily() ||
!serviceWorkerURL.protocolIsInHTTPFamily() || protocolHostAndPortAreEqual(url,
serviceWorkerURL));

I can probably remove url.isEmpty()


More information about the webkit-reviews mailing list