[webkit-reviews] review granted: [Bug 183004] [GStreamer] Rewrite purgeInvalid*Tracks methods : [Attachment 334382] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 21 08:46:10 PST 2018


Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 183004: [GStreamer] Rewrite purgeInvalid*Tracks methods
https://bugs.webkit.org/show_bug.cgi?id=183004

Attachment 334382: Patch

https://bugs.webkit.org/attachment.cgi?id=334382&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 334382
  --> https://bugs.webkit.org/attachment.cgi?id=334382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334382&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1458
> +    m_audioTracks.removeIf([&](auto& keyAndValue) {

I prefer to explicitly capture validTrackIds& only


More information about the webkit-reviews mailing list