[webkit-reviews] review granted: [Bug 182968] [GStreamer] Create a Wayland GL display instead of EGL : [Attachment 334264] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 21 01:27:41 PST 2018
Xabier RodrÃguez Calvar <calvaris at igalia.com> has granted review:
Bug 182968: [GStreamer] Create a Wayland GL display instead of EGL
https://bugs.webkit.org/show_bug.cgi?id=182968
Attachment 334264: Patch
https://bugs.webkit.org/attachment.cgi?id=334264&action=review
--- Comment #3 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 334264
--> https://bugs.webkit.org/attachment.cgi?id=334264
Patch
Before the patch landed on https://bugzilla.gnome.org/show_bug.cgi?id=743062
these references were still floating, thus we can't adopt or we would get
crashes in debug mode. After that patch, we need to adopt or we would be
leaking. I think we can land as it is but we need a new bug to fix this.
More information about the webkit-reviews
mailing list