[webkit-reviews] review granted: [Bug 181825] [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower : [Attachment 334286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 20 22:55:30 PST 2018


Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 181825: [GTK] USE_UPOWER causes crashes inside a chroot or on systems with
broken dbus/upower
https://bugs.webkit.org/show_bug.cgi?id=181825

Attachment 334286: Patch

https://bugs.webkit.org/attachment.cgi?id=334286&action=review




--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 334286
  --> https://bugs.webkit.org/attachment.cgi?id=334286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334286&action=review

> Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp:100
> +    if (m_cancellable)
> +	   g_cancellable_cancel(m_cancellable.get());

g_cancellable_cancel is null safe.


More information about the webkit-reviews mailing list