[webkit-reviews] review granted: [Bug 182959] DFG::VarargsForwardingPhase should eliminate getting argument length : [Attachment 334302] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 20 20:09:58 PST 2018


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 182959: DFG::VarargsForwardingPhase should eliminate getting argument
length
https://bugs.webkit.org/show_bug.cgi?id=182959

Attachment 334302: patch

https://bugs.webkit.org/attachment.cgi?id=334302&action=review




--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 334302
  --> https://bugs.webkit.org/attachment.cgi?id=334302
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334302&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGVarargsForwardingPhase.cpp:202
> +		   if (node->child1()->op() == GetButterfly
> +		       && candidateButterflies.contains(node->child1().node())
> +		       && node->child2() == candidate
> +		       && node->storageAccessData().offset ==
clonedArgumentsLengthPropertyOffset) {
> +		       ASSERT(node->child1()->child1() == candidate);

Might be worth a static_assert that clonedArgumentsLengthPropertyOffset is out
of line.


More information about the webkit-reviews mailing list