[webkit-reviews] review granted: [Bug 182834] Switch to UIWKTextInteractionAssistant for non-editable text : [Attachment 334323] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 20 17:19:46 PST 2018
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 182834: Switch to UIWKTextInteractionAssistant for non-editable text
https://bugs.webkit.org/show_bug.cgi?id=182834
Attachment 334323: Patch
https://bugs.webkit.org/attachment.cgi?id=334323&action=review
--- Comment #19 from Tim Horton <thorton at apple.com> ---
Comment on attachment 334323
--> https://bugs.webkit.org/attachment.cgi?id=334323
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334323&action=review
> Source/WebKit/ChangeLog:4
> + https://bugs.webkit.org/show_bug.cgi?id=182834
rdar here
> Source/WebKit/ChangeLog:7
> +
Did you lose overall patch words from before?
> Source/WebKit/ChangeLog:12
> + (-[WKContentView gestureRecognizerShouldBegin:]):
Might write some words here about this one (since this is the only new one that
isn't obvious).
More information about the webkit-reviews
mailing list