[webkit-reviews] review denied: [Bug 182980] [CMake] Split declaration of JSC headers into public and private : [Attachment 334291] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 182980: [CMake] Split declaration of JSC headers into public and private
https://bugs.webkit.org/show_bug.cgi?id=182980

Attachment 334291: Patch

https://bugs.webkit.org/attachment.cgi?id=334291&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334291
  --> https://bugs.webkit.org/attachment.cgi?id=334291
Patch

Problem is the public headers are different for different ports. GTK and WPE
hardcode the list of non-Objective C headers in PlatformGTK.cmake and
PlatformWPE.cmake. Best to clean this up now: add two separate lists of public
framework headers, one for the C API, and one for Objective C. And get rid of
the WPE and GTK-specific lists.