[webkit-reviews] review granted: [Bug 182933] [GTK][CMake] Support building with Enchant 2.x : [Attachment 334172] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 20 09:32:34 PST 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 182933: [GTK][CMake] Support building with Enchant 2.x
https://bugs.webkit.org/show_bug.cgi?id=182933
Attachment 334172: Patch
https://bugs.webkit.org/attachment.cgi?id=334172&action=review
--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334172
--> https://bugs.webkit.org/attachment.cgi?id=334172
Patch
This looks good, just swap the order so enchant-2 is checked first, and please
add a FIXME to remove the check for old enchant after a couple of years.
More information about the webkit-reviews
mailing list