[webkit-reviews] review granted: [Bug 182974] [EME] Adopt new AVContentKeySession success delegate callback : [Attachment 334273] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 20 08:49:55 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 182974: [EME] Adopt new AVContentKeySession success delegate callback
https://bugs.webkit.org/show_bug.cgi?id=182974

Attachment 334273: Patch

https://bugs.webkit.org/attachment.cgi?id=334273&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 334273
  --> https://bugs.webkit.org/attachment.cgi?id=334273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334273&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.mm:490
> +void
CDMInstanceFairPlayStreamingAVFObjC::requestDidSucceed(AVContentKeyRequest
*request)

Nit: you should just omit the parameter since it can never be used.


More information about the webkit-reviews mailing list