[webkit-reviews] review granted: [Bug 182962] [WebVR][OpenVR] Retrieve eye parameters and field of view : [Attachment 334269] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 182962: [WebVR][OpenVR] Retrieve eye parameters and field of view
https://bugs.webkit.org/show_bug.cgi?id=182962

Attachment 334269: Patch

https://bugs.webkit.org/attachment.cgi?id=334269&action=review




--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 334269
  --> https://bugs.webkit.org/attachment.cgi?id=334269
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334269&action=review

> Source/WebCore/Modules/webvr/VREyeParameters.h:36
> +class IntSize;

This can be dropped.

> Source/WebCore/platform/vr/VRPlatformDisplay.h:24
> +#include "IntSize.h"

This can be dropped.

> Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.cpp:61
> +    /* OpenVR returns the tangents of the half-angles from the center view
axis. */

// is a more common single-line comment pattern.

> Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.cpp:68
> +    for (unsigned eye = 0; eye < VRPlatformDisplayInfo::NumEyes; eye++) {

Usually better to increment via prefix: `++eye`.