[webkit-reviews] review granted: [Bug 182958] [Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext : [Attachment 334250] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 182958: [Cairo] Leverage ShadowBlur without using scratch buffer, target
GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=182958

Attachment 334250: Patch

https://bugs.webkit.org/attachment.cgi?id=334250&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 334250
  --> https://bugs.webkit.org/attachment.cgi?id=334250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334250&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:181
> +    if (image) {

Use an early return here.

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:237
> +	   (GraphicsContext& shadowContext)

Move this to previous line for consistency with other lambdas.