[webkit-reviews] review granted: [Bug 182957] Make more use of USE(OPENGL_ES) where it makes sense : [Attachment 334247] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 182957: Make more use of USE(OPENGL_ES) where it makes sense
https://bugs.webkit.org/show_bug.cgi?id=182957

Attachment 334247: Patch

https://bugs.webkit.org/attachment.cgi?id=334247&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 334247
  --> https://bugs.webkit.org/attachment.cgi?id=334247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334247&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.h:64
> +#else // PLATFORM(COCOA)

This is confusing. Maybe just #endif // PLATFORM(COCOA) then #if
!PLATFORM(COCOA)?

> Source/WebCore/platform/graphics/GraphicsContext3D.h:66
> +#endif // PLATFORM(COCOA)

Confusing.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:72
> +#else // __OBJC__

Also.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:80
> +#else // PLATFORM(COCOA)

As well.