[webkit-reviews] review granted: [Bug 182782] [FTL] Support ArrayPush for ArrayStorage : [Attachment 333785] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 19 19:18:28 PST 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 182782: [FTL] Support ArrayPush for ArrayStorage
https://bugs.webkit.org/show_bug.cgi?id=182782

Attachment 333785: Patch

https://bugs.webkit.org/attachment.cgi?id=333785&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 333785
  --> https://bugs.webkit.org/attachment.cgi?id=333785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333785&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4478
> +	   case Array::ArrayStorage: {

Is SlowPutArrayStorage not possible?

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4488
> +		   LValue prevLength = m_out.load32(storage,
m_heaps.Butterfly_publicLength);
> +		   // Refuse to handle bizarre lengths.
> +		   speculate(Uncountable, noValue(), nullptr,
m_out.above(prevLength, m_out.constInt32(largestPositiveInt32Length)));

You can move this code above the if since you do it below too.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4497
> +		       unsure(slowPath), unsure(fastPath));

You can probably use likely/unlikely here

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4535
> +	       m_out.branch(beyondVectorLength, unsure(slowPath),
unsure(fastPath));

you can probably use likely/unlikely here.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4563
> +	       m_out.branch(beyondVectorLength, unsure(slowCallPath),
unsure(continuation));

could probably use likely/unlikely here.


More information about the webkit-reviews mailing list