[webkit-reviews] review granted: [Bug 180898] AX: AOM: Dispatch accessibleclick event : [Attachment 334221] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 19 19:15:51 PST 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Nan Wang <n_wang at apple.com>'s
request for review:
Bug 180898: AX: AOM: Dispatch accessibleclick event
https://bugs.webkit.org/show_bug.cgi?id=180898

Attachment 334221: patch

https://bugs.webkit.org/attachment.cgi?id=334221&action=review




--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334221
  --> https://bugs.webkit.org/attachment.cgi?id=334221
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334221&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:999
> +	       Ref<Event> event =
Event::create(eventNames().accessibleclickEvent, true, true);

Use auto.

> Source/WebCore/accessibility/AccessibilityObject.cpp:2164
> +    EventDispatcher::dispatchEvent(eventPath, event);

The definition of the event dispatching isn't detailed enough in the current
spec...
Filed https://github.com/WICG/aom/issues/103.


More information about the webkit-reviews mailing list