[webkit-reviews] review denied: [Bug 182792] [FTL] Support HasIndexedProperty for ArrayStorage : [Attachment 333791] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 182792: [FTL] Support HasIndexedProperty for ArrayStorage
https://bugs.webkit.org/show_bug.cgi?id=182792

Attachment 333791: Patch

https://bugs.webkit.org/attachment.cgi?id=333791&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 333791
  --> https://bugs.webkit.org/attachment.cgi?id=333791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333791&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   [FTL] Support HasIndexedProperty for ArrayStorage

And SlowPutArrayStorage.

> Source/JavaScriptCore/ChangeLog:8
> +	   This patch adds HasIndexedProperty for ArrayStorage in FTL.

And SlowPutArrayStorage.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:9781
> +		   m_out.jump(checkHole);

This needs to do a speculation check that it's not out of bounds. Seems like
this should be testable via crashing on some OOB read. You also won't need a
"checkHole" dedicated block if it's in bounds, you can just use the incoming
block we're emitting code in.