[webkit-reviews] review granted: [Bug 182942] Don't use JSFunction's allocation profile when getting the prototype can be effectful : [Attachment 334204] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 182942: Don't use JSFunction's allocation profile when getting the
prototype can be effectful
https://bugs.webkit.org/show_bug.cgi?id=182942

Attachment 334204: patch

https://bugs.webkit.org/attachment.cgi?id=334204&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 334204
  --> https://bugs.webkit.org/attachment.cgi?id=334204
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334204&action=review

r=me

> Source/JavaScriptCore/ChangeLog:23
> +	   the allocation profile when the prototype property is
non-configurable
> +	   and non-writable.

Per our offline discussion, non-writable is not applicable.

> Source/JavaScriptCore/runtime/JSFunction.h:135
> -    FunctionRareData* rareData(ExecState* exec, unsigned inlineCapacity)
> +    FunctionRareData* ensureRareDataAndAllocationProfile(ExecState* exec,
unsigned inlineCapacity)
>      {
> +	   ASSERT(canUseAllocationProfileNonInline());

You can move this function to Inlines.h and forego needing
canUseAllocationProfileNonInline().