[webkit-reviews] review granted: [Bug 182927] Crash under MIMETypeRegistry::isSupportedJavaScriptMIMEType() : [Attachment 334185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 19 14:09:45 PST 2018
Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 182927: Crash under MIMETypeRegistry::isSupportedJavaScriptMIMEType()
https://bugs.webkit.org/show_bug.cgi?id=182927
Attachment 334185: Patch
https://bugs.webkit.org/attachment.cgi?id=334185&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 334185
--> https://bugs.webkit.org/attachment.cgi?id=334185
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334185&action=review
> Source/WebCore/platform/MIMETypeRegistry.cpp:502
> + if (!isMainThread()) {
> + bool isSupported = false;
> + callOnMainThreadAndWait([&isSupported, mimeType =
mimeType.isolatedCopy()] {
> + isSupported = isSupportedJavaScriptMIMEType(mimeType);
> + });
> + return isSupported;
> + }
It would be nice to make MIMETypeRegistry thread safe in a way that does not
involve blocking on main thread.
More information about the webkit-reviews
mailing list