[webkit-reviews] review granted: [Bug 182903] [Web Animations] Store all parsed keyframe input information in a single structure : [Attachment 334107] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 182903: [Web Animations] Store all parsed keyframe input information in a
single structure
https://bugs.webkit.org/show_bug.cgi?id=182903

Attachment 334107: Patch

https://bugs.webkit.org/attachment.cgi?id=334107&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 334107
  --> https://bugs.webkit.org/attachment.cgi?id=334107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334107&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:85
> +	   keyframe.computedOffset = keyframe.offset ? keyframe.offset.value()
: 0;

keyframe.offset.value_or(0)

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:442
> +	   ParsedKeyframe parsedKeyframe;
> +	   parsedKeyframe.easing = sourceParsedKeyframe.easing;
> +	   parsedKeyframe.offset = sourceParsedKeyframe.offset;
> +	   parsedKeyframe.composite = sourceParsedKeyframe.composite;
> +	   parsedKeyframe.unparsedStyle = sourceParsedKeyframe.unparsedStyle;
> +	   parsedKeyframe.computedOffset = sourceParsedKeyframe.computedOffset;
> +	   parsedKeyframe.timingFunction = sourceParsedKeyframe.timingFunction;
> +	   parsedKeyframe.style = sourceParsedKeyframe.style->mutableCopy();

You should make a operator= for this.