[webkit-reviews] review granted: [Bug 155198] IFrame is resized incorrectly on orientation change : [Attachment 334041] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 155198: IFrame is resized incorrectly on orientation change
https://bugs.webkit.org/show_bug.cgi?id=155198

Attachment 334041: Patch

https://bugs.webkit.org/attachment.cgi?id=334041&action=review




--- Comment #6 from Antonio Gomes <tonikitoo at webkit.org> ---
Comment on attachment 334041
  --> https://bugs.webkit.org/attachment.cgi?id=334041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334041&action=review

r+ w/ nits

>
LayoutTests/fast/events/ios/rotation/resize-iframe-after-orientation-change.htm
l:26
> +		       uiController.simulateRotation('${orientation}',
function() {

let use either single or double quote throughout the test.

>
LayoutTests/fast/events/ios/rotation/resize-iframe-after-orientation-change.htm
l:43
> +	     await rotateDevice('portrait');
> +	     var output = document.getElementById("output");
> +	     var outer = document.getElementById("outer");
> +	     shouldBe('document.getElementById("frame").scrollWidth',
'outer.scrollWidth');
> +	    
shouldBe('document.getElementById("frame").contentDocument.getElementById("inne
r").scrollWidth', 'outer.scrollWidth');

ditto, unless where the difference makes sense.