[webkit-reviews] review granted: [Bug 182919] Increase text autosizing constants for extra zoom mode : [Attachment 334137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 19 00:25:38 PST 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 182919: Increase text autosizing constants for extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=182919

Attachment 334137: Patch

https://bugs.webkit.org/attachment.cgi?id=334137&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 334137
  --> https://bugs.webkit.org/attachment.cgi?id=334137
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334137&action=review

> Source/WebCore/page/Settings.yaml:724
> +maxScaleIncrease:

Nit - perhaps a more specific name, such as maxTextAutosizingScaleIncrease? At
first glance, `maxScaleIncrease` sounds a bit like a viewporty thing.


More information about the webkit-reviews mailing list