[webkit-reviews] review denied: [Bug 182784] Fix ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren : [Attachment 334004] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 16 21:43:28 PST 2018
Ryosuke Niwa <rniwa at webkit.org> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 182784: Fix
ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren
https://bugs.webkit.org/show_bug.cgi?id=182784
Attachment 334004: Patch
https://bugs.webkit.org/attachment.cgi?id=334004&action=review
--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334004
--> https://bugs.webkit.org/attachment.cgi?id=334004
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334004&action=review
>> Source/WebCore/ChangeLog:13
>> + No new tests (No behavior change)
>
> This is definitely a behavior change... maybe you could explain at a
higher-level what you've fixed, why this is correct, and why it's hard to write
a test for it.
Yes, we definitely need a test.
More information about the webkit-reviews
mailing list