[webkit-reviews] review granted: [Bug 182878] [RenderTreeBuilder] Move RenderElement::addChild() to RenderTreeBuilder : [Attachment 334049] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 16 10:27:15 PST 2018
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 182878: [RenderTreeBuilder] Move RenderElement::addChild() to
RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182878
Attachment 334049: Patch
https://bugs.webkit.org/attachment.cgi?id=334049&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 334049
--> https://bugs.webkit.org/attachment.cgi?id=334049
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334049&action=review
> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:325
> parent.RenderElement::insertChildInternal(WTFMove(child), beforeChild);
> + parent.RenderElement::didInsertChild(newChild, beforeChild);
RenderElement:: is probably not needed in either case.
More information about the webkit-reviews
mailing list