[webkit-reviews] review granted: [Bug 182815] Support scrolling for non-editable web-selection and start autoscroll when near screen edges : [Attachment 333954] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 182815: Support scrolling for non-editable web-selection and start
autoscroll when near screen edges
https://bugs.webkit.org/show_bug.cgi?id=182815

Attachment 333954: Patch

https://bugs.webkit.org/attachment.cgi?id=333954&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 333954
  --> https://bugs.webkit.org/attachment.cgi?id=333954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333954&action=review

> Source/WebCore/page/ios/EventHandlerIOS.mm:591
> +    FloatPoint edgeDistanceThreashold = toFloatPoint(screenRect.size());

Still threashold????

> Source/WebCore/page/ios/EventHandlerIOS.mm:592
> +    edgeDistanceThreashold.scale(1. / 10);

Maybe reconsider the 10% part? It seems weird that the threshold will be wildly
different between iPad Pro and a small iPhone.

> Source/WebCore/page/ios/EventHandlerIOS.mm:633
> +    // This will need to be revisited if delegatedScrolling is updated

Updated? I don’t think we need this comment.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1828
> +    else if (!m_assistedNode) {

Probably can just be an else.