[webkit-reviews] review granted: [Bug 182830] [Modern Media Controls] REGRESSION: Inline media controls are not disabled while in fullscreen on iOS : [Attachment 333899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 15 09:25:45 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 182830: [Modern Media Controls] REGRESSION: Inline media controls are not
disabled while in fullscreen on iOS
https://bugs.webkit.org/show_bug.cgi?id=182830

Attachment 333899: Patch

https://bugs.webkit.org/attachment.cgi?id=333899&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 333899
  --> https://bugs.webkit.org/attachment.cgi?id=333899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333899&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:310
> +	   // Controls are always available while in fullscreen on macOS.

Nit: you might add something like this for clarity - ", and they are never
available when in fullscreen on iOS".


More information about the webkit-reviews mailing list